I had this discussion at work today. Mine would be Graeme Sharp who was brilliant for Everton but just couldn't make the jump to international level. Others mentioned were Steve Archibald, Duncan Ferguson, Brian McClair, Willie Pettigrew and (bizarrely imo) Graeme Souness.
Who is your biggest disappointment in a Scotland Jersey despite looking as though they should be in cruise control?